-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add label.iconSVG key #976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean for it to come across as a complaint.
I was just looking for a confirmation on the matter to proceed with the PR.
I had already said we can go ahead in discord. Anyways about the svg height, we don't need to implement that.
It is redundant to add iconHeight to replace height in svg. User can add height directly in svg.
Originally posted by @adityatelange in #974 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed!
|
Usage => Params.label.iconSVG: "<your SVG as a string>"
Usage => Params.label.iconSVG: "<your SVG as a string>"
Usage => Params.label.iconSVG: "<your SVG as a string>"
Usage => Params.label.iconSVG: "<your SVG as a string>"
What does this PR change? What problem does it solve?
This PR adds
label.iconSVG
key under site params. It can be used to embed the SVG directly for easier styling, e.g. for handling the change between dark and light mode.Was the change discussed in an issue or in the Discussions before?
Closes #974.
PR Checklist