Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add update version script and gh action #298

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Conversation

sbenedicadb
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #298 (7a955c6) into main (b1fb6e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          28       28           
  Lines        1649     1649           
=======================================
  Hits         1592     1592           
  Misses         57       57           

then
echo "********** USAGE ERROR **********"
echo "Some or all of the parameters are empty. See usage below:";
help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to exit early for missing required params when running this in a non-interactive mode like the gh action

required: true

branch:
description: 'Branch to be used when updating versions'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to include a branch picker here instead of text input?

Copy link
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged, and will let you experiment with the other two changes and add them as incremental updates

@emdobrin emdobrin merged commit d5e42ab into adobe:main Mar 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants