Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update tutorial for Android Core 2.0 version parity #300

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

timkimadobe
Copy link
Contributor

Description

Updates tutorial to have parity with Android Core 2.0 tutorial performing cleanup for doc links and wording/instructions based on feedback.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #300 (6baf305) into dev (880f5ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #300   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          28       28           
  Lines        1045     1045           
=======================================
  Hits          998      998           
  Misses         47       47           

@emdobrin emdobrin added the documentation Improvements or additions to documentation label Feb 9, 2023
Copy link
Contributor Author

@timkimadobe timkimadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @emdobrin! Addressed feedback with latest updates, with a couple outstanding questions

@timkimadobe timkimadobe merged commit 87cf465 into adobe:dev Feb 17, 2023
@timkimadobe timkimadobe deleted the update-tutorial-android-parity branch February 17, 2023 21:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants