-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update tutorial for Android Core 2.0 version parity #300
Merged
timkimadobe
merged 6 commits into
adobe:dev
from
timkimadobe:update-tutorial-android-parity
Feb 17, 2023
Merged
Update tutorial for Android Core 2.0 version parity #300
timkimadobe
merged 6 commits into
adobe:dev
from
timkimadobe:update-tutorial-android-parity
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkimadobe
commented
Jan 25, 2023
Codecov Report
@@ Coverage Diff @@
## dev #300 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 28 28
Lines 1045 1045
=======================================
Hits 998 998
Misses 47 47 |
emdobrin
reviewed
Feb 9, 2023
timkimadobe
commented
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @emdobrin! Addressed feedback with latest updates, with a couple outstanding questions
emdobrin
approved these changes
Feb 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates tutorial to have parity with Android Core 2.0 tutorial performing cleanup for doc links and wording/instructions based on feedback.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: