-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[CI] Run unit and functional tests separately in CI #368
Conversation
Update CircleCI script accordingly
Codecov Report
@@ Coverage Diff @@
## dev #368 +/- ##
==========================================
+ Coverage 96.68% 96.73% +0.05%
==========================================
Files 27 27
Lines 1626 1653 +27
==========================================
+ Hits 1572 1599 +27
Misses 54 54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @emdobrin! Reordered unit and functional tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good but it appears there are still test failures in CI. Are those failures expected?
In the CircleCI configuration, I'd recommend running the unit and functional tests in separate steps, instead of just one step which runs both sequentially. The reason is when a failure occurs it is hard to know if the failure is from the unit or functional tests. For example, in this failure the last few lines displayed show a functional test failure but searching through the entire log shows a unit test failed as well. |
Description
This PR:
Related Issue
Motivation and Context
For future reference, the old method required extracting the true scheme, with output like (note the duplicate AEPEdge scheme differentiated with parentheses):
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: