Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

MenuSection insertion doesn't work, but docs suggest it should #1210

Closed
peterflynn opened this issue Jul 1, 2012 · 5 comments · Fixed by #1247
Closed

MenuSection insertion doesn't work, but docs suggest it should #1210

peterflynn opened this issue Jul 1, 2012 · 5 comments · Fixed by #1247
Assignees

Comments

@peterflynn
Copy link
Member

Add this code to any extension:

Menus.getMenu(Menus.AppMenuBar.FILE_MENU)
    .addMenuItem(Commands.TOGGLE_USE_TAB_CHARS, null, Menus.LAST, Menus.MenuSection.FILE_SAVE_MENU);

Result: Menu item is added to the bottom of the File menu.
Expected: Added below Save, above Live File Preview.

The docs on MenuSection and on addMenuItem() both imply that using MenuSection constants works, but afaik from looking at the code we never got around to implementing it. If we don't have time to add the functionality now, we should remove the constants for now & update docs to say it isn't supported.

@ghost ghost assigned tvoliter Jul 1, 2012
@peterflynn
Copy link
Member Author

Nominating for Sprint 11 since it'd be good to have the menu APIs stabilized by then.

@redmunds
Copy link
Contributor

FBNC back to @peterflynn

@peterflynn peterflynn reopened this Jul 18, 2012
@peterflynn
Copy link
Member Author

Darn GitHub autoclosing... reopening until I can actually verify...

@peterflynn
Copy link
Member Author

Hmm... bug is mysteriously closed again. One more try at reopening here...

@peterflynn peterflynn reopened this Jul 21, 2012
@peterflynn
Copy link
Member Author

Confirmed fixed, but filed new bugs #1292 and #1293

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants