Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CLOSED] MenuSection insertion doesn't work, but docs suggest it should #1195

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Sunday Jul 01, 2012 at 23:43 GMT
Originally opened as adobe/brackets#1210


Add this code to any extension:

Menus.getMenu(Menus.AppMenuBar.FILE_MENU)
    .addMenuItem(Commands.TOGGLE_USE_TAB_CHARS, null, Menus.LAST, Menus.MenuSection.FILE_SAVE_MENU);

Result: Menu item is added to the bottom of the File menu.
Expected: Added below Save, above Live File Preview.

The docs on MenuSection and on addMenuItem() both imply that using MenuSection constants works, but afaik from looking at the code we never got around to implementing it. If we don't have time to add the functionality now, we should remove the constants for now & update docs to say it isn't supported.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Sunday Jul 01, 2012 at 23:44 GMT


Nominating for Sprint 11 since it'd be good to have the menu APIs stabilized by then.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Jul 17, 2012 at 16:28 GMT


FBNC back to@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 18, 2012 at 23:40 GMT


Darn GitHub autoclosing... reopening until I can actually verify...

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Jul 21, 2012 at 19:56 GMT


Hmm... bug is mysteriously closed again. One more try at reopening here...

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Sunday Jul 22, 2012 at 21:23 GMT


Confirmed fixed, but filed new bugs #1292 and #1293

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant