Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Quick Open lists git metafiles #1221

Closed
peterflynn opened this issue Jul 9, 2012 · 0 comments
Closed

Quick Open lists git metafiles #1221

peterflynn opened this issue Jul 9, 2012 · 0 comments

Comments

@peterflynn
Copy link
Member

  1. Open a project that contains a .git folder (this doesn't typically happen with Brackets since the .git folder is up in brackets-app, but if you include any extensions with a .git folder then you'll hit this)
  2. Hit Ctrl+Shift+O

Result: the list will usually show lots of entries that are just big hex values, inside .git/objects/

Expected: filter out contents of .git folder

There's some Mac-specific code to hide dotfiles and dotfolder contents, but it's incomplete (e.g. Thumbs.db still gets listed) and doesn't run at all on Win.

It would be great if we could just share the code in ProjectManager._shouldShowInTree() for this. FileIndexManager._scanDirectoryRecurse() should call this code on folders to terminate the recursion early, and either it or _addFileToIndexes() should apply it to filter out files too.

@ghost ghost assigned peterflynn Jul 10, 2012
peterflynn added a commit that referenced this issue Jul 10, 2012
…ager's

existing file/folder filtering logic as a public API, and use it in
FileIndexManager too for consistency (which provides the file list for
Quick Open).
tvoliter added a commit that referenced this issue Jul 12, 2012
* origin/master: (21 commits)
  Improve console output of LiveDevelopment errors
  store and retrieve tree state for each project
  Fix issue #1221 (Quick Open lists git metafiles) -- Expose ProjectManager's existing file/folder filtering logic as a public API, and use it in FileIndexManager too for consistency (which provides the file list for Quick Open).
  Simplify the dialog creation as suggested by Glenn, but I use prependTo to keep the DOM structure the same as the original code.
  fix typo
  code review changes
  wait for styles to load
  Replace DOM manipulation code with equvilent jQuery api calls.
  fix positioned menu dividers
  Fix CodeMirror SHA
  Fixing nested single quotes. Reverted to escaped nested doubles around single.
  Updated quotes and syntax to fix errors
  Fix some incorrect quotes
  fix dirty dot layout
  Update source to adhere to style guide for quotes. Fixes issue #1100.
  fix name conflict
  allow long file names to wrap lines
  when file not found, remove it from working set
  apply improvement to multiple file open
  project switching performance changes for working set
  ...
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

1 participant