Error Launching Browser (error 1) if Chrome not installed - not a helpful error message

[dalcala]

Description:
On Win 8.1, when I try to run Live Preview before I've installed Chrome, I get Error Launching Browser (error 1). I would expect the error message to say Chrome is not installed. There is a link to "Troubleshooting Live Development connection errors": https://github.com/adobe/brackets/wiki/Troubleshooting#wiki-livedev, but that page doesn't mention anything about "error 1". That page also doesn't clearly say that you need Chrome for Live Preview to work. The one-time Live Preview dialog does say you need Chrome, but that's only a one-time dialog and maybe some users need to see this again in the troubleshooting page.

Related to #5047

Repro using Brackets Sprint 33 10187 on Win 8.1.

Repro steps:

1. I was testing on Win 8.1 (not sure if it repros on other OS's).
2. Chrome was not installed yet.
3. Open index.html from Getting Started and run Live Preview.

Actual results:
Error message appears: Error Launching Browser. "An error occurred when launching the browser. (error 1) For more information, see "Troubleshooting Live Development connection errors": https://github.com/adobe/brackets/wiki/Troubleshooting#wiki-livedev, but that page doesn't mention anything about "error 1".

Expected results:
Error message says Chrome is not installed.
If that's not possible, then https://github.com/adobe/brackets/wiki/Troubleshooting#wiki-livedev should mention "error 1" and say you need Chrome.
Also, the punctuation of the error message seems strange. I think it should be something like this:
"An error occurred when launching the browser (error 1). For more information..."

Workaround:
Figure out on your own that you need Chrome installed.

[marcelgerber]

So the normal error code when Chrome/Chromium isn't installed is 1 - why is it 3 in #5763?

[njx]

To @bchintx to look into - if this error code basically means "can't start the Chrome process", maybe we could at least map it to a more friendly message that says something like "Either Chrome is not installed or we couldn't launch it". (But if it doesn't reliably map to that, then we might want to do something more specific to try to determine whether Chrome actually is installed--if that ends up being a bunch of work, I'd be less inclined to do it as a bug fix.)

Either way, we should consider updating the troubleshooting wiki page as @SAplayer suggested.

[bchintx]

So, my above pull request is no longer needed to fix this bug. Looks like the constant value was already corrected by the change to update to Glenn's new native FileSystem API (see Pull Request #5797). As a result, the fix has already been merged to master.

@dalcala Can you please verify and close this issue as fixed? Thanks!

[bchintx]

Confirming fixed using Sprint 37 installed on my Win 8.1 tablet. Without Chrome installed, I get an "Error launching browser" dialog that explains that "The Google Chrome browser could not be found....". Closing this issue as fixed.