This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixes "JS Quick Open doesn't recognize functions with multiline arguments" #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…take2 * origin/master: Issue 1072. Use getDocumentForPath instead of getOpenDocumentForPath.
…take2 * origin/master: Tweak context menu event handling to support Windows context menu key. In general, anything using with mouse coords for purposes other than menu positioning should use mousedown, while the menu itself should be popped up via contextmenu. Update CodeMirror SHA Code review comments Add "variable" token type to JavaScriptQuickEdit. Update unit tests. Filter for valid function expressions
ghost
assigned 
| @@ -421,7 +421,7 @@ define(function (require, exports, module) { | |||
| PerfUtils.createPerfMeasurement("JSUTILS_REGEXP", "RegExp search for all functions"); | |||
| PerfUtils.createPerfMeasurement("JSUTILS_END_OFFSET", "Find end offset for a single matched function"); | |||
|
|
|||
| exports._findAllMatchingFunctionsInText = _findAllMatchingFunctionsInText; // For testing only | |||
| exports.findAllMatchingFunctionsInText = findAllMatchingFunctionsInText; // For testing only | |||
There was a problem hiding this comment.
Remove \\ For testing only
|
Finished with initial review. Need to merge with master. |
…take2 * origin/master: now that the working set view handles mousedown instead of click in order to capture left and right clicks, it's necessary to call preventDefault() so the focus is not removed from the editor. remove high ascii file fix typo git munged high ascii in file name, so use only low ascii Fix typo Update ExtensionLoader require paths to include text plugin. Update InlineImageViewer to use text plugin to load an HTML template. Correct showInlineEditor to toggleQuickEdit. Updated all references and ran unit tests. Fix SHOW_INLINE_EDITOR command handler to return a promise. Clean up Debug menu (issues #977, #1056): - Move JSLint to View menu; Use Tabs to Edit menu - Remove "Experimental" heading - Remove "Close Browsers" command (after discussion w/ Glenn) - underlying NativeApp API not removed since it's still used by unit tests - Reorder remaining Debug menu items - Rename "Reload Window"->"Reload Brackets" for clarity - Rename "New Window"->"New Brackets Window" for clarity - Move JSLint command impl to JSLintUtils - (Left Use Tabs impl in DebugCommandHandlers for now until it has a more natural home) Add unit tests for filtering out token types in JavaScript Quick Edit. initial set of tests complete intermediate checkin for first unit test RequireJS text plugin 1.0.8 Conflicts: src/extensions/default/JavaScriptQuickEdit/unittests.js
|
The merge is a little tricky though I am through most of it. Will have my fixes pushed soon. |
…take2 * origin/master: fix JSLint warning add New command back to project context menu Fix issues Jason raised in code review. don't toggle open folders on right-click Code review Provide Indent/Unindent in Edit menu. close menus on scroll Resolve loadStyleSheet with the created link element select tree node on right-click
|
Code review fixes pushed |
| @@ -23,27 +23,22 @@ | |||
|
|
|||
|
|
|||
| /*jslint vars: true, plusplus: true, devel: true, browser: true, nomen: true, indent: 4, maxerr: 50 */ | |||
| /*global define, describe, it, xit, expect, beforeEach, afterEach, waitsFor, waitsForDone, runs, $, brackets */ | |||
| /*global define: false, describe: false, it: false, xit: false, expect: false, beforeEach: false, afterEach: false, waitsFor: false, runs: false, $: false, brackets: false, waitsForDone */ | |||
There was a problem hiding this comment.
Undo this change. We're taking out the readonly arg here since it defaults to false.
|
A few minor comments before merging. Unit tests pass on OS X 10.7. It's worth doing a smoke test pass too if you get the chance. |
|
Thanks Jason. Fixes pushed. I ran unit tests and smokes look good as well. -----Original Message----- A few minor comments before merging. Unit tests pass on OS X 10.7. It's worth doing a smoke test pass too if you get the chance. Reply to this email directly or view it on GitHub: |
jasonsanjose
added a commit
that referenced
this pull request
Jun 22, 2012
Fixes "JS Quick Open doesn't recognize functions with multiline arguments"
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #924, JS Quick Open doesn't recognize functions with multiline arguments
@jason-sanjose Could you review? I think you are the most familiar with this code.