This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Resolve loadStyleSheet with the created link element #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
reviewing |
| @@ -591,4 +591,4 @@ ins.jstree-icon { | |||
| li.smart_autocomplete_highlight { | |||
| background-color: #5fa3e0; | |||
|
|
|||
| } | |||
| } No newline at end of file | |||
There was a problem hiding this comment.
It looks like you removed the extra line at the end of the file. It should work ok, but I am curious why?
I find editing easier with an extra empty line, and I have run into very rare cases where it did cause a problem, so I always make a point of having an extra line at the end of each file.
There was a problem hiding this comment.
Inadvertent. Fixed.
|
initial review complete |
|
@redmunds Pushed fix. |
redmunds
added a commit
that referenced
this pull request
Jun 21, 2012
Resolve loadStyleSheet with the created link element
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows extensions to manipulate or remove the created style sheet. Also, flattened some style hierarchy for the inline editor related rules list.