Fix async issues in brackets-shell #1185
Conversation
….markStart() calls to unique strings. Return $.Promise in cases where file access is async.
ghost
assigned 
|
|
||
| var result = new $.Deferred(), promise = result.promise(); | ||
| var result = new $.Deferred(); | ||
|
|
||
| if (!fullPath) { | ||
| console.log("doOpen() called without fullPath"); | ||
| result.reject(); | ||
| return promise; |
There was a problem hiding this comment.
There's still a reference to promise here. I'm fine with removing the var though.
|
Done reviewing |
|
Addressed comments in the last 2 commits. However, I'm seeing failures on windows in CEF1 that I need to review. |
|
@peterflynn false alarm. My preferences were wedged. Unit tests pass for me on mac and win using CEF1 with and without forceAsync. |
|
@jason-sanjose: did you check in the actual brackets-shell too? (The Win build is still on zerowing somewhere... not sure about a Mac build, but I assume Raymond could get you one today). |
|
@peterflynn Just got it working. Had to run each suite individually in brackets-shell as well. I hit 3 more failures:
I'm taking a look at the first one now. I didn't see the other 2 accounted for in brackets-shell. I'll update in a bit. |
|
I filed https://github.com/adobe/brackets-shell/issues/26 to log the LowLevelFileIO failure. I also fixed the inline editor provider failure (another async issue). The nativefilesystem test is failing because it can't find the matcher that was added via addMatcher(). Not sure how that happened. I think this pull request is in the clear though. |
|
@peterflynn I got brackets-shell on win to pass fully. I had to fix some async issues in NativeFileSystem-tests. No fixes to core. |
| SpecRunnerUtils.clickDialogButton(Dialogs.DIALOG_BTN_DONTSAVE); | ||
|
|
||
| waitsForDone(promise); |
There was a problem hiding this comment.
clickDialogButton() is already supposed to wait for the dialog to close. If this line is needed, something's broken there (I guess its no longer guaranteed that timeouts in one window are sequenced interleaved with timeouts in another window?). We should try to fix clickDialogButton() itself instead of patching around it here.
There was a problem hiding this comment.
Ah, thanks for catching that. It was unecessary.
|
I think with the |
…ckets into jason-sanjose/perf-utils-async
Conflicts: src/document/DocumentCommandHandlers.js
|
Fixed |
|
Cool -- merging. |
Fix async issues in brackets-shell that were causing unit tests to fail. Change more unit tests to use waitsForDone().
documentidentifiersgetDocumentForPathTested on 10.7 using brackets-app with forceAsync=true and on windows with the sprint 10 brackets-shell build. I did hit 1 lowlevelfileIO failure on windows 7 that isn't related to the scope of the sprint 11 CEF3 bugs.