This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Implement esc key to close pop-ups and inline widgets #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
The change in focus management breaks all commands that apply to inline editors. Now they all get redirected to the main editor instead. We could try to add a real focus manager, but that feels like scope creep for what was supposed to be a smallish story. Would it be simpler to just remove the part of this diff that tries to put focus on open menus? (Making Esc close menus too wasn't officially part of the story's requirements). |
| if (!event.isDefaultPrevented()) { | ||
| keyEvent.stopImmediatePropagation(); | ||
|
|
||
| _removePopUp($popUp, true); |
There was a problem hiding this comment.
It seems like calling the "_"-prefixed one here means we'll leak by leaving the entry in _popUps...
|
It turns out, the ESC key stuff still work with Menus even after undoing my fix. I threw it in there since it seemed like a bug to type while the menu was open. |
|
@tvoliter or @peterflynn ... ready to review |
|
When working on the unit tests, I notice that the contextMenuClose event does not fire when closing via Esc key. |
|
Ooops, github did not update the page. I'll open an issue. |
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Feb 19, 2017
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Feb 21, 2017
Renames and indents fix modified README
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Feb 21, 2017
Renames and indents fix modified README fixed typo in readme
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Feb 24, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Feb 24, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Mar 7, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Mar 7, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes merge conflict
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Mar 7, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes merge conflict small fix
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Mar 29, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes merge conflict small fix Fixed issue where the initial state of auto close tags (true) did not reflect in the editor statemanager mistake clean up Fixed error with editor not reflecting auto close initially Modified README and StateManager Typo in README fixed Modified UI.js and RemoteCommanderHandler.js as requested
cgsingh
added a commit
to cgsingh/brackets
that referenced
this pull request
Mar 29, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes merge conflict small fix Fixed issue where the initial state of auto close tags (true) did not reflect in the editor statemanager mistake clean up Fixed error with editor not reflecting auto close initially Modified README and StateManager Typo in README fixed Modified UI.js and RemoteCommanderHandler.js as requested
humphd
added a commit
to mozilla/brackets
that referenced
this pull request
Mar 30, 2017
Fix adobe#1262 - Option to disable Auto-Enclosing Tags
Rajat-dhyani
pushed a commit
to Rajat-dhyani/brackets
that referenced
this pull request
Apr 20, 2017
Renames and indents fix modified README fixed typo in readme Make things work Modified README Added setObject wrapper function changes merge conflict small fix Fixed issue where the initial state of auto close tags (true) did not reflect in the editor statemanager mistake clean up Fixed error with editor not reflecting auto close initially Modified README and StateManager Typo in README fixed Modified UI.js and RemoteCommanderHandler.js as requested
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigned to @tvoliter
Note: I noticed that
MenusandCodeHintManagershare positioning logic. It makes sense to refactor this intoPopUpManagerin the future.