Change indent width UI #1818
Change indent width UI #1818
Conversation
ghost
assigned 
|
There's a tooltip over Tab Size/Spaces, but there's no tooltip over the number. The underscore during mouseover is so small for the number that it's possible to cover it up with the mouse pointer, so it seems like it worth adding. |
|
Are there supposed to be spinner up/down arrows like in Garth's prototype? If so, I'm not seeing them. But, I discovered that up/down arrows work. |
|
The new prototype doesn't have spinners http://garthdb.github.com/Brackets-UI-Prototypes/status_bar/ |
| function _changeIndentSize(inc) { | ||
| function _changeIndentWidth(value) { | ||
| $indentWidthLabel.toggleClass("hidden"); | ||
| $indentWidthInput.toggleClass("hidden"); |
There was a problem hiding this comment.
Seems like it's possible to get into the opposite state than what is desired with the hidden class because you assume it's applied and toggleClass() will remove it. Same comment for handling "click" event: it assumes hidden is not applied and toggleClass() will add it.
I think it will be safer to be more explicit about your intentions by using removeClass("hidden") here and addClass("hidden") when handling the "click" event.
|
Good idea on the tooltip. I've added that in my last commit. |
| @@ -136,36 +135,50 @@ a, img { | |||
| font-size: 1.4em; | |||
| } | |||
|
|
|||
| #status-indent div { | |||
| #status-indent * { | |||
There was a problem hiding this comment.
Using the universal selector as a descendent selector selects every element in the DOM sub-tree. Is that what you want? If you only meant to apply it to immediate children then use the child combinator:
#status-indent > *
|
Done with initial review |
|
@redmunds thanks! Fixes pushed. |
|
Looks good. Merging. |
Use Garth's updated statusbar Ui.