Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[BezierEditor] Fix fadeout issue #7248

Merged

Conversation

marcelgerber
Copy link
Contributor

Steps to reproduce the issue, introduced by #7235:

  1. Start an Inline Timing Function Editor
  2. Make the function invalid, like cubic-bezier(1.000001, 0, 0, 0)
  3. Make it valid again
  4. Make some other valid changes (like deleting the additional zeros) while the fadeout is still running

Result: The hint is immediately hidden
Expected: The fadeout should continue

This PR makes the code a bit cleaner (using editor.hint object for everything that has to do with the hint) and uses .hide(), suggested by @zaggino.

@redmunds redmunds self-assigned this Mar 19, 2014
@redmunds
Copy link
Contributor

@SAplayer I could review pull requests faster if the branch names weren't so long :)

@marcelgerber
Copy link
Contributor Author

@redmunds I'll try to use a shorter one next time ;)

@njx
Copy link

njx commented Mar 19, 2014

@redmunds Try https://github.com/defunkt/hub - then you can do things like hub checkout https://github.com/adobe/brackets/pull/7248

@peterflynn
Copy link
Member

I always just copy-paste the branch name from the top of the PR into the terminal, personally :-) Or you can click the "command line" link at bottom (next to the merge button) and copy the full command line to the clipboard in 1 click...

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request Mar 21, 2014
…fadeout-fix

[BezierEditor] Fix fadeout issue
@redmunds redmunds merged commit 70053ae into adobe:master Mar 21, 2014
@marcelgerber marcelgerber deleted the inline-timing-function-editor-fadeout-fix branch March 21, 2014 22:27
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants