DINT-1543 Add taxAmount and priceTotal to AEP order #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadiyaS
reviewed
Aug 1, 2024
| @@ -44,6 +44,8 @@ const createOrder = ( | |||
| payments, | |||
| orderType, | |||
| discountAmount: orderContext?.discountAmount, | |||
| priceTotal: Number(orderContext?.grandTotal || 0), | |||
| taxAmount: Number(orderContext?.taxAmount || 0), | |||
There was a problem hiding this comment.
do we really wants to set tax amount as 0? Should we include all scenarios with different tax configurations in the QA?
There was a problem hiding this comment.
I think we just want to avoid null scenarios, and if it is null then we set to 0.
There was a problem hiding this comment.
0 is the value. Just don't want to have case when order has taxes but we didn't receive it from the context and set this value as 0.
Let's leave it for now. But need to create a separate ticket to test different scenarios with taxes
There was a problem hiding this comment.
A null value would cause the event to not be processed by AEP. That is why we set it to 0.
NadiyaS
approved these changes
Aug 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding taxAmount and priceTotal to appropriate schema and in AEP order creation utility function to populate the same fields in AEP events.
Data Service changes https://github.com/magento-commerce/data-services/pull/209
Related Issue
https://jira.corp.adobe.com/browse/DINT-1543
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist