Added check for visibility attribute specifier #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavanaanand
added
enhancement
fosterbrereton
requested changes
Nov 8, 2019
matchers/utilities.cpp
Outdated
| case Visibility::ProtectedVisibility: | ||
| info["visibility"] = "protected"; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I'd rather there not be a default option. That way in case these enumerations change we get a compiler warning about them, instead of values going blank unexpectedly.
| @@ -38,7 +38,9 @@ void FunctionInfo::run(const MatchFinder::MatchResult& Result) { | |||
| auto function = Result.Nodes.getNodeAs<FunctionDecl>("func"); | |||
|
|
|||
| // Do not process class methods here. | |||
| if (llvm::dyn_cast_or_null<CXXMethodDecl>(function)) return; | |||
| if (!_options._process_class_methods) { | |||
There was a problem hiding this comment.
Can you explain a bit why this is necessary?
|
LGTM! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves Hyde with following capabilities -
visibilityandvisibility_explicitattributes to the JSON method info