Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle editable scalar value that is an unexpected tag #57

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

baheath
Copy link
Collaborator

@baheath baheath commented Mar 27, 2020

Make sure we handle cases where an editable scalar has a value that is an unexpected tag.

This scenario can happen if someone edits the value from, say __MISSING__ to __OPTIONAL__ or if we change a field within Hyde from optional to required, for example. Before, we would have have accepted such a value. Now, it will be a validation error, and will corrected to the expected tag during the update operation.

…s an unexpected tag.

This scenario can happen if someone edits the value from, say `__MISSING__` to `__OPTIONAL__` or if we change a field within Hyde from optional to required, for example. Before, we would have have accepted such a value. Now, it will be a validation error, and will corrected to the expected tag during the update operation.
@baheath baheath requested a review from fosterbrereton March 27, 2020 15:12
Copy link
Contributor

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baheath baheath merged commit ef8a91b into master Mar 27, 2020
@baheath baheath deleted the bheath/handle-scalar-with-tag branch March 27, 2020 17:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants