Fix various build problems #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems resolved are: - Ignoring a multiline comment in LLVM9 - Adding return statements to methods where gcc cannot deduct that a case will always result in a return being executed.
|
LGTM; thank you for these changes! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Wno-commendin theCMakeLists.txtRelated Issue
#69
Motivation and Context
Why is this change required? This change is required to build on Ubuntu 20.04 with LLVM9
*What problem does it solve? * This enables building on Ubuntu 20.04 with LLMV9
How Has This Been Tested?
I didn't find any automated tests to fun, but I ran the
Screenshots (if appropriate):
N/A
Types of changes
Checklist:
I have added tests to cover my changes.All new and existing tests passed.