fix(contrast-colors): Add d3 as dependency #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joestrouth1 good catch! Note that we don't use I don't think it needs to be a peer dependency, so this is good to go. Thank you! |
|
Released |
|
Also, that issue on bootstrap was due to referring to the wrong version in the |
Merged
thierryc
pushed a commit
to thierryc/leonardo
that referenced
this pull request
Mar 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #24
Package depended on d3 without declaring so.
To-do list
Should be OK to merge unless you'd prefer it be a peer dep so folks can bring their own version.
Aside:
When cloning this repo and running
lerna bootstrap, it failed with the following error:I think this will fix itself once it's not tagged as prerelease, but as someone not super familiar with lerna it was a bit of a barrier. Wound up changing the package.json version to 0.1.0, bootstrapping, then changing back after adding d3.