-
Notifications
You must be signed in to change notification settings - Fork 211
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(picker): add forcePopover property (#5041)
Co-authored-by: Casey Eickhoff <ceickhoff@adobe.com>
- Loading branch information
1 parent
7a5f786
commit 3651e57
Showing
11 changed files
with
449 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 181 additions & 0 deletions
181
packages/action-menu/test/action-menu-responsive.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| /* | ||
| Copyright 2020 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import { | ||
| elementUpdated, | ||
| expect, | ||
| fixture, | ||
| html, | ||
| nextFrame, | ||
| oneEvent, | ||
| } from '@open-wc/testing'; | ||
| import { ActionMenu } from '@spectrum-web-components/action-menu'; | ||
| import '@spectrum-web-components/action-menu/sync/sp-action-menu.js'; | ||
| import '@spectrum-web-components/menu/sp-menu-divider.js'; | ||
| import '@spectrum-web-components/menu/sp-menu-item.js'; | ||
| import { setViewport } from '@web/test-runner-commands'; | ||
| import { spreadProps } from '../../../test/lit-helpers.js'; | ||
| import { sendMouse } from '../../../test/plugins/browser.js'; | ||
|
|
||
| describe('ActionMenu, responsive', () => { | ||
| let el: ActionMenu; | ||
| const actionMenuFixture = async (args?: { | ||
| forcePopover: boolean; | ||
| }): Promise<ActionMenu> => { | ||
| const test = await fixture<HTMLDivElement>(html` | ||
| <div> | ||
| <sp-action-menu id="action-menu" ${spreadProps(args || {})}> | ||
| <span slot="label">Action Menu</span> | ||
| <sp-menu-item>Deselect</sp-menu-item> | ||
| <sp-menu-item>Select Inverse</sp-menu-item> | ||
| <sp-menu-item>Feather...</sp-menu-item> | ||
| <sp-menu-item>Select and Mask...</sp-menu-item> | ||
| <sp-menu-divider></sp-menu-divider> | ||
| <sp-menu-item>Save Selection</sp-menu-item> | ||
| <sp-menu-item disabled>Make Work Path</sp-menu-item> | ||
| </sp-action-menu> | ||
| </div> | ||
| `); | ||
|
|
||
| return test.querySelector('sp-action-menu') as ActionMenu; | ||
| }; | ||
|
|
||
| describe('container', () => { | ||
| beforeEach(async () => { | ||
| el = await actionMenuFixture(); | ||
| await elementUpdated(el); | ||
| }); | ||
|
|
||
| it('is a Tray in mobile', async () => { | ||
| /** | ||
| * This is a hack to set the `isMobile` property to true so that we can test the MobileController | ||
| */ | ||
| el.isMobile.matches = true; | ||
| el.bindEvents(); | ||
|
|
||
| /** | ||
| * While we can set the view port, but not `(hover: none) and (pointer: coarse)` | ||
| * which prevents us from testing this at unit time. Hopefully there will be | ||
| * a future version of Playwright and/or @web/test-runner that does allow this. | ||
| * See: https://github.com/microsoft/playwright/issues/11781 | ||
| **/ | ||
| await setViewport({ width: 360, height: 640 }); | ||
| // Allow viewport update to propagate. | ||
| await nextFrame(); | ||
|
|
||
| const opened = oneEvent(el, 'sp-opened'); | ||
|
|
||
| const boundingRect = el.button.getBoundingClientRect(); | ||
| sendMouse({ | ||
| steps: [ | ||
| { | ||
| type: 'click', | ||
| position: [ | ||
| boundingRect.x + boundingRect.width / 2, | ||
| boundingRect.y + boundingRect.height / 2, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| await opened; | ||
|
|
||
| const tray = el.shadowRoot.querySelector('sp-tray'); | ||
| const popover = el.shadowRoot.querySelector('sp-popover'); | ||
|
|
||
| expect(tray).to.not.be.null; | ||
| expect(popover).to.be.null; | ||
| }); | ||
|
|
||
| it('is a Popover in desktop', async () => { | ||
| await setViewport({ width: 701, height: 640 }); | ||
| // Allow viewport update to propagate. | ||
| await nextFrame(); | ||
| await nextFrame(); | ||
|
|
||
| const opened = oneEvent(el, 'sp-opened'); | ||
| el.open = true; | ||
| await opened; | ||
|
|
||
| const popover = el.shadowRoot.querySelector('sp-popover'); | ||
| const tray = el.shadowRoot.querySelector('sp-tray'); | ||
|
|
||
| expect(popover).to.not.be.null; | ||
| expect(tray).to.be.null; | ||
| }); | ||
| }); | ||
|
|
||
| describe('forcePopover', () => { | ||
| beforeEach(async () => { | ||
| el = await actionMenuFixture({ forcePopover: true }); | ||
| await elementUpdated(el); | ||
| }); | ||
|
|
||
| it('is a Popover in mobile', async () => { | ||
| /** | ||
| * This is a hack to set the `isMobile` property to true so that we can test the MobileController | ||
| */ | ||
| el.isMobile.matches = true; | ||
| el.bindEvents(); | ||
|
|
||
| /** | ||
| * While we can set the view port, but not `(hover: none) and (pointer: coarse)` | ||
| * which prevents us from testing this at unit time. Hopefully there will be | ||
| * a future version of Playwright and/or @web/test-runner that does allow this. | ||
| * See: https://github.com/microsoft/playwright/issues/11781 | ||
| **/ | ||
| await setViewport({ width: 360, height: 640 }); | ||
| // Allow viewport update to propagate. | ||
| await nextFrame(); | ||
|
|
||
| const opened = oneEvent(el, 'sp-opened'); | ||
|
|
||
| const boundingRect = el.button.getBoundingClientRect(); | ||
| sendMouse({ | ||
| steps: [ | ||
| { | ||
| type: 'click', | ||
| position: [ | ||
| boundingRect.x + boundingRect.width / 2, | ||
| boundingRect.y + boundingRect.height / 2, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| await opened; | ||
|
|
||
| const tray = el.shadowRoot.querySelector('sp-tray'); | ||
| const popover = el.shadowRoot.querySelector('sp-popover'); | ||
|
|
||
| expect(tray).to.be.null; | ||
| expect(popover).to.not.be.null; | ||
| }); | ||
|
|
||
| it('is a Popover in desktop', async () => { | ||
| await setViewport({ width: 701, height: 640 }); | ||
| // Allow viewport update to propagate. | ||
| await nextFrame(); | ||
| await nextFrame(); | ||
|
|
||
| const opened = oneEvent(el, 'sp-opened'); | ||
| el.open = true; | ||
| await opened; | ||
|
|
||
| const popover = el.shadowRoot.querySelector('sp-popover'); | ||
| const tray = el.shadowRoot.querySelector('sp-tray'); | ||
|
|
||
| expect(popover).to.not.be.null; | ||
| expect(tray).to.be.null; | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.