fix(split-button): test a11y correctly, find issues, fix them

adobe · Sep 3, 2020 · 4283994 · 4283994
1 parent 00aa940
commit 4283994
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/split-button/src/SplitButton.ts b/packages/split-button/src/SplitButton.ts
@@ -144,6 +144,7 @@ export class SplitButton extends DropdownBase {
                     @click=${this.onButtonClick}
                     @focus=${this.onButtonFocus}
                     ?disabled=${this.disabled}
+                    aria-label="More"
                 >
                     <sp-icon
                         class="icon ${this.type === 'field'

diff --git a/packages/split-button/test/split-button.test.ts b/packages/split-button/test/split-button.test.ts
@@ -33,8 +33,8 @@ describe('Splitbutton', () => {
         await elementUpdated(el1);
         await elementUpdated(el2);
 
-        expect(el1).to.be.accessible();
-        expect(el2).to.be.accessible();
+        await expect(el1).to.be.accessible();
+        await expect(el2).to.be.accessible();
     });
     it('loads [type="more"] splitbutton accessibly', async () => {
         const test = await fixture<HTMLDivElement>(moreCta());
@@ -44,8 +44,8 @@ describe('Splitbutton', () => {
         await elementUpdated(el1);
         await elementUpdated(el2);
 
-        expect(el1).to.be.accessible();
-        expect(el2).to.be.accessible();
+        await expect(el1).to.be.accessible();
+        await expect(el2).to.be.accessible();
     });
     it('manages tab interactions', async () => {
         const test = await fixture<HTMLDivElement>(moreCta());