fix: leverage "dvh" rather than measured screen height

adobe · Dec 2, 2022 · 84b9df0 · 84b9df0
1 parent 628ec2c
commit 84b9df0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/packages/overlay/src/ActiveOverlay.ts b/packages/overlay/src/ActiveOverlay.ts
@@ -283,18 +283,8 @@ export class ActiveOverlay extends SpectrumElement {
 
         this.state = 'active';
 
-        // force paint
-        // this prevents a timing issue that can show up in tests as
-        // 'Error: Timeout: Wait for decorator to become ready...'
-        this.offsetWidth;
-
         this.feature();
-        if (this.placement === 'none') {
-            this.style.setProperty(
-                '--swc-visual-viewport-height',
-                `${window.innerHeight}px`
-            );
-        } else if (this.placement) {
+        if (this.placement && this.placement !== 'none') {
             await this.updateOverlayPosition();
             document.addEventListener(
                 'sp-update-overlays',

diff --git a/packages/overlay/src/active-overlay.css b/packages/overlay/src/active-overlay.css
@@ -50,8 +50,8 @@ governing permissions and limitations under the License.
 :host([placement='none']) {
     position: fixed;
     height: 100vh;
+    height: 100dvh;
     height: fill-available;
-    max-height: var(--swc-visual-viewport-height);
     top: 0;
     left: 0;
 }

diff --git a/packages/tray/src/tray.css b/packages/tray/src/tray.css
@@ -16,7 +16,8 @@ governing permissions and limitations under the License.
 :host {
     align-items: flex-end;
     position: fixed !important;
-    max-height: var(--swc-visual-viewport-height);
+    max-height: 100vh;
+    max-height: 100dvh;
 }
 
 sp-underlay {