chore: remove unused positionlistbox method

adobe · Jan 18, 2024 · e6bfd12 · e6bfd12
1 parent 5e7c770
commit e6bfd12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/packages/combobox/src/Combobox.ts b/packages/combobox/src/Combobox.ts
@@ -263,16 +263,6 @@ export class Combobox extends Textfield {
         return super.shouldUpdate(changed);
     }
 
-    private positionListbox(): void {
-        const targetRect = this.overlay.getBoundingClientRect();
-        const rootRect = this.getBoundingClientRect();
-        this.listbox.style.transform = `translate(${
-            targetRect.x - rootRect.x
-        }px, ${targetRect.y - rootRect.y}px)`;
-        this.listbox.style.height = `${targetRect.height}px`;
-        this.listbox.style.maxHeight = `${targetRect.height}px`;
-    }
-
     protected override onBlur(event: FocusEvent): void {
         if (
             event.relatedTarget &&

diff --git a/packages/combobox/test/combobox.test.ts b/packages/combobox/test/combobox.test.ts
@@ -86,7 +86,7 @@ describe('Combobox', () => {
             const test = await fixture<HTMLDivElement>(html`
                 <div>${withFieldLabel()}</div>
             `);
-            const el = test.querySelector('sp-combobox') as Combobox;
+            const el = test.querySelector('sp-combobox') as unknown as Combobox;
 
             await elementUpdated(el);
 
@@ -96,7 +96,7 @@ describe('Combobox', () => {
             const test = await fixture<HTMLDivElement>(html`
                 <div>${withFieldLabel()}</div>
             `);
-            const el = test.querySelector('sp-combobox') as Combobox;
+            const el = test.querySelector('sp-combobox') as unknown as Combobox;
             const name = 'Pick something';
             const webkitName = 'Pick something Bde Thing 2';
             type NamedNode = { name: string; role: string; value?: string };