-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Some files in the styles package need to be manually kept in sync with SpectrumCSS #308
Comments
@Westbrook it'd be good to know if this is just a matter of making some small updates to |
Looks like it’s here https://github.com/adobe/spectrum-css/blob/master/components/typography/font.css so I’d say, yes. |
Hmmm... I thought it was here: https://github.com/adobe/spectrum-css/blob/master/components/commons/fonts.css (but now I'm wondering if both need to be reconciled) |
I just linked the first one I could find. If it’s available in an individual package and not a bundle, I’m not too concerned where we pull from. All of those GitHub files are all facades for processed files in the delivered package, anyways. |
Right, but the 2 files we linked are different. I'm guessing we want to variable one I linked, but I'm still not totally up to speed on the conversion script (will try to take a look next week though). |
Added the @spectrum-css/commons package since we need to source our fonts.css from 2 file to get what we need. Also updated the generation script to allow building from multiple source files. Fixes #308
Added the @spectrum-css/commons package since we need to source our fonts.css from 2 file to get what we need. Also updated the generation script to allow building from multiple source files. Fixes #308
Added the @spectrum-css/commons package since we need to source our fonts.css from 2 file to get what we need. Also updated the generation script to allow building from multiple source files. Fixes #308
Expected Behaviour
We have an automated process to update variable changes from SpectrumCSS
Actual Behaviour
At least some files need to be updated, like https://github.com/adobe/spectrum-web-components/blob/master/packages/styles/fonts.css (which is currently out of date).
The text was updated successfully, but these errors were encountered: