Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Some files in the styles package need to be manually kept in sync with SpectrumCSS #308

Closed
adixon-adobe opened this issue Nov 22, 2019 · 5 comments · Fixed by #319
Closed
Labels
1.0.0 Issues that should be addressed for a 1.0 release!

Comments

@adixon-adobe
Copy link
Collaborator

Expected Behaviour

We have an automated process to update variable changes from SpectrumCSS

Actual Behaviour

At least some files need to be updated, like https://github.com/adobe/spectrum-web-components/blob/master/packages/styles/fonts.css (which is currently out of date).

@adixon-adobe adixon-adobe added the 1.0.0 Issues that should be addressed for a 1.0 release! label Nov 22, 2019
@adixon-adobe
Copy link
Collaborator Author

@Westbrook it'd be good to know if this is just a matter of making some small updates to scripts/process-spectrum-css.js or if there's still some larger work to do to properly integrate the SpectrumCSS lerna changes.

@Westbrook
Copy link
Contributor

@adixon-adobe
Copy link
Collaborator Author

Hmmm... I thought it was here: https://github.com/adobe/spectrum-css/blob/master/components/commons/fonts.css (but now I'm wondering if both need to be reconciled)

@Westbrook
Copy link
Contributor

Westbrook commented Nov 22, 2019

I just linked the first one I could find. If it’s available in an individual package and not a bundle, I’m not too concerned where we pull from. All of those GitHub files are all facades for processed files in the delivered package, anyways.

@adixon-adobe
Copy link
Collaborator Author

Right, but the 2 files we linked are different. I'm guessing we want to variable one I linked, but I'm still not totally up to speed on the conversion script (will try to take a look next week though).

adixon-adobe added a commit that referenced this issue Nov 26, 2019
Added the @spectrum-css/commons package since we need to source our
fonts.css from 2 file to get what we need. Also updated the generation
script to allow building from multiple source files. Fixes #308
adixon-adobe added a commit that referenced this issue Dec 2, 2019
Added the @spectrum-css/commons package since we need to source our
fonts.css from 2 file to get what we need. Also updated the generation
script to allow building from multiple source files. Fixes #308
Westbrook pushed a commit that referenced this issue Dec 2, 2019
Added the @spectrum-css/commons package since we need to source our
fonts.css from 2 file to get what we need. Also updated the generation
script to allow building from multiple source files. Fixes #308
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1.0.0 Issues that should be addressed for a 1.0 release!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants