fix(textfield): textarea actually grows with multiline #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromecolor-field permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
number-field permalinkbasic-test
search permalinktest-basic
slider permalinktest-basic
textfield permalinktest-basic
Firefoxcolor-field permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
number-field permalinkbasic-test
search permalinktest-basic
slider permalinktest-basic
textfield permalinktest-basic
|
Westbrook
reviewed
Apr 22, 2024
Westbrook
reviewed
Apr 22, 2024
…um-web-components into blunteshwar/sp-textarea-bug
|
Currently ends up with textarea always one line longer than the actual text: |
|
@blunteshwar lets try to add a re-review request after a full VRT test pass going forward to save time of the review process? |
…um-web-components into blunteshwar/sp-textarea-bug
Sure! Will keep in mind from next time |
Westbrook
reviewed
Apr 25, 2024
Co-authored-by: Westbrook Johnson <wesjohns@adobe.com>
…um-web-components into blunteshwar/sp-textarea-bug
Rajdeepc
pushed a commit
that referenced
this pull request
Apr 26, 2024
* fix(textfield): textarea actually grows with multiline * chore(textfield): added a test * chore(textfield): css changes * chore(textfield): added changes to css * Update textfield.test.ts * chore(textfield): reverting css changes as they didn't work * fix(textfield): added css fix * fix(textfield): fixed the extra spacing in render method * fix(textfield): fixed spacing * fix(textfield): fixed spacing * fix(textfield): fixed spacing * fix(textfield): fix spacing * fix(textfield): fixed spacing * fix(textfield): fixed spacing inside render method * chore(textfield): suggested changes Co-authored-by: Westbrook Johnson <wesjohns@adobe.com> * chore(textfield): removed unrequired css props --------- Co-authored-by: Westbrook Johnson <wesjohns@adobe.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sp-textarea was not growing when typing multiple lines of text, so I updated the
heightof textarea withscrollHeightRelated issue(s)
#4259
Motivation and context
It updates the height of textarea with attributes {multiline,grows} when typing multiple lines of text.
How has this been tested?
Screenshots (if appropriate)
Screen.Recording.2024-04-16.at.5.42.01.PM.mov
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.