Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(picker): correct implementation of "disabled", expand stories and documentation #4040

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Westbrook
Copy link
Contributor

Description

  • prevent [disabled] Picker from opening
  • test to confirm
  • add [disabled] story to confirm
  • expand to leverage template.ts and args.ts to populate interactive documentation page

Related issue(s)

How has this been tested?

  • Test case 1
    1. Go here
    2. Toggle the demo at the top of the page to disabled===true
    3. Attempt to open the picker by clicking on it.
    4. See that it does not open

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Westbrook Westbrook requested a review from a team February 13, 2024 22:21
Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.93 0.93 0.97
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Copy link

Tachometer results

Chrome

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 655 kB 171.40ms - 178.15ms - unsure 🔍
-3% - +3%
-5.22ms - +5.04ms
branch 647 kB 171.00ms - 178.73ms unsure 🔍
-3% - +3%
-5.04ms - +5.22ms
-

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 518 kB 615.87ms - 626.96ms - unsure 🔍
-1% - +1%
-7.41ms - +7.65ms
branch 509 kB 616.19ms - 626.39ms unsure 🔍
-1% - +1%
-7.65ms - +7.41ms
-

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 721 kB 1858.79ms - 1861.99ms - unsure 🔍
-0% - +0%
-2.27ms - +2.01ms
branch 713 kB 1859.10ms - 1861.94ms unsure 🔍
-0% - +0%
-2.01ms - +2.27ms
-
Firefox

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 655 kB 336.68ms - 346.60ms - unsure 🔍
-2% - +2%
-8.15ms - +7.87ms
branch 647 kB 335.49ms - 348.07ms unsure 🔍
-2% - +2%
-7.87ms - +8.15ms
-

picker permalink

Version Bytes Avg Time vs remote vs branch
npm latest 518 kB 1031.27ms - 1041.53ms - unsure 🔍
-2% - +1%
-18.01ms - +13.29ms
branch 509 kB 1023.97ms - 1053.55ms unsure 🔍
-1% - +2%
-13.29ms - +18.01ms
-

split-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 721 kB 1569.44ms - 1573.00ms - unsure 🔍
-0% - +0%
-1.27ms - +3.99ms
branch 713 kB 1567.92ms - 1571.80ms unsure 🔍
-0% - +0%
-3.99ms - +1.27ms
-

Copy link
Collaborator

@najikahalsema najikahalsema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making this change.

@najikahalsema najikahalsema merged commit 84c2fef into main Feb 13, 2024
48 checks passed
@najikahalsema najikahalsema deleted the picker-disabled branch February 13, 2024 23:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Picker SWC cannot be disabled on Chrome
2 participants