You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S_DiscoverOutline_18_N@2x.svgS_Discover_18_N@2x.svgS_Enterprise_18_N@2x.svgS_Government_18_N@2x.svgS_Learn_18_N@2x.svgS_OfferActivities_18_N@2x.svgS_Offers_18_N@2x.svgS_Placeholder_18_N@2x.svgS_ResolvedComment_18_N@2x.svgS_Tableau_18_N@2x.svgS_TreeView_18_N@2x.svgS_UnresolvedComment_18_N@2x.svgS_VerticalMasonryGridView_18_N@2x.svgS_ViewCardOneCol_18_N@2x.svgS_ViewTable_18_N@2x.svg and Discover.jsDiscoverOutline.jsEnterprise.jsGovernment.jsLearn.jsOfferActivities.jsOffers.jsPlaceholder.jsResolvedComment.jsTreeView.jsUnresolvedComment.jsVerticalMasonryGridView.jsViewCardOneCol.jsViewTable.js
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.
The reason will be displayed to describe this comment to others. Learn more.
Much of this data could be sourced from the @adobe/spectrum-css-workflow-icons/dist/icons.json in a future iteration (would need a little clean-up because it's pascal case with *.svg postfixes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing S1 icons as listed below.
The release is taken from, v1.7.0
https://www.npmjs.com/package/@adobe/spectrum-css-workflow-icons/v/1.7.0?activeTab=code
Missing icons added
Related issue(s)
-https://jira.corp.adobe.com/browse/SWC-624
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.