Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Authorization URL Update discord.ts #151

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

cjpitch23
Copy link
Contributor

@cjpitch23 cjpitch23 commented May 31, 2024

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have fixed the url used for Discord oath2 authorization. It required the removal of the /api part in the route in accordance with Discords OAuth2 documentation (read here: https://discord.com/developers/docs/topics/oauth2).

Furthermore, I added a parameter to the request called "integration_type" and I set the value to 1. Though the Discord documentation states that it is unnecessary unless a specific scope is being called, I kept receiving an error that said "Installation type not supported for this application". I solved it by adding the integration type and setting it to user install.

πŸ“ Checklist

I have not linked an issue or discussion, as I did not see one. I also do not believe this change will require any change to the documentation.

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@RomainLanz RomainLanz merged commit 6bb90d5 into adonisjs:develop Jun 1, 2024
5 checks passed
@RomainLanz
Copy link
Member

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants