Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce property notif change with tracked-built-ins #517

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

snewcomer
Copy link
Collaborator

ref #499

@snewcomer snewcomer self-assigned this Jun 28, 2020
@snewcomer snewcomer changed the title Reduce proprerty notif change with tracked-built-ins Reduce property notif change with tracked-built-ins Jun 30, 2020
@betocantu93
Copy link
Contributor

Hello! got here after following a few issues about all props being notified, what's stopping this PR to be merged? 🤔 thanks!!

@snewcomer
Copy link
Collaborator Author

@betocantu93 That is a great question! I actually don't know if it will work yet. We will have to do some testing to see how we can be more granular in our property notification updates. Certainly a worthwhile investigation!

@betocantu93
Copy link
Contributor

betocantu93 commented Apr 7, 2021

Hello @snewcomer this PR may fix or at least its a way to fix this issue: #586, its actually based on this one in the sense of avoiding replacing the CHANGES entirely in favor of setDeep and instead make sure to notify nested paths

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants