Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix autocomplete clear button's position when floating label is used #560

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

xomaczar
Copy link
Contributor

This closes #539

@xomaczar xomaczar force-pushed the patch-539 branch 2 times, most recently from c3b5148 to d3eaa44 Compare November 14, 2016 06:18
@miguelcobain
Copy link
Collaborator

@xomaczar thanks for the PR.
Can you summarize this change?
What exactly happened to the backport? Is it just a copy-pasted version of latest AM styles for autocomplete?

@xomaczar
Copy link
Contributor Author

@miguelcobain Sure, no problem - tried to comment as much as I could.

  1. The backported autocomplete style is simply a copy-pasted version of the latest AM styles @1.1.1
  2. In the new AM autocomplete style the md-autocomplete-suggestions-containers height/max-height properties were removed, so to make it compatible I added those back. (Later on we can make the necessary autocomplete changes in paper-autocomplete/component.js and remove height/max-height from css - match AM style)

Hope this helps.

@xomaczar
Copy link
Contributor Author

@miguelcobain does that explain my changes?

@xomaczar
Copy link
Contributor Author

can you merge this PR?

@xomaczar
Copy link
Contributor Author

rebased

@miguelcobain miguelcobain merged commit a312d4a into adopted-ember-addons:master Nov 22, 2016
@xomaczar xomaczar deleted the patch-539 branch December 22, 2016 05:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paper-autocomplete + floating label + allowClear=true
2 participants