Adds support for default first broker login flow on realm level #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-krauss
force-pushed
the
feat/add-support-for-default-first-broker-login-flow
branch
10 times, most recently
from
f549d97 to
79e3444
Compare
maximilian-krauss
force-pushed
the
feat/add-support-for-default-first-broker-login-flow
branch
2 times, most recently
from
0519c05 to
d1d55ed
Compare
maximilian-krauss
force-pushed
the
feat/add-support-for-default-first-broker-login-flow
branch
2 times, most recently
from
285a7d1 to
311fc39
Compare
AssahBismarkabah
requested review from
AssahBismarkabah,
francis-pouatcha and
st3v0rr
There was a problem hiding this comment.
Hello @maximilian-krauss
i tested the corresponding modifications with a custom authentication flow configuration , and the test case seems to be successful locally, but the workflow build for version 23.0.7 have some test failures, please can you look into it
Errors:
[ERROR] ImportParallelImportIT.shouldCreateRealm:51->AbstractImportTest.doImport:69->AbstractImportTest.doImport:76 » ImportProcessing de.adorsys.keycloak.config.exception.ImportProcessingException: Cannot find created group 'group10' in realm 'realmWithParallelImport'
[ERROR] ImportParallelImportIT.shouldUpdateRealm:59->AbstractImportTest.doImport:69->AbstractImportTest.doImport:76 » WebApplication HTTP 500 Internal Server Error
[INFO]
311fc39 to
109b4b4
Compare
|
maximilian-krauss
force-pushed
the
feat/add-support-for-default-first-broker-login-flow
branch
from
109b4b4 to
3cf7956
Compare
# Conflicts: # .github/workflows/ci.yaml # CHANGELOG.md # pom.xml
maximilian-krauss
force-pushed
the
feat/add-support-for-default-first-broker-login-flow
branch
from
3cf7956 to
fd13afa
Compare
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for a custom default first broker login flow defined on realm level:
Without these changes the CLI was not able to import/update the firstBrokerLoginFlow because it was missing the special treatment like
browserFloworregistrationFlow.Special notes for your reviewer:
Have a nice day 🙂
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR