Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve error logging for Keycloak responses #1271

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

AssahBismarkabah
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah commented Feb 5, 2025

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@AssahBismarkabah AssahBismarkabah linked an issue Feb 5, 2025 that may be closed by this pull request
@AssahBismarkabah AssahBismarkabah added enhancement java Pull requests that update Java code labels Feb 5, 2025
Copy link

@DenuxPlays DenuxPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is what we needed :)
Thanks

@AssahBismarkabah AssahBismarkabah force-pushed the 1270-failing-with-400-bad-request branch from 5dc08c0 to 1f7ca1c Compare February 6, 2025 09:30
Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Motouom Motouom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!

@Motouom Motouom merged commit 1977131 into main Feb 12, 2025
17 checks passed
@Motouom Motouom deleted the 1270-failing-with-400-bad-request branch February 12, 2025 08:29
@Motouom Motouom restored the 1270-failing-with-400-bad-request branch February 12, 2025 08:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing with 400 Bad Request
4 participants