fixes #1278: Updating attributes of a user, which has no attributes set, will work now

src/main/java/de/adorsys/keycloak/config/service/UserImportService.java

@@ -152,7 +152,7 @@ private void updateUser(UserRepresentation existingUser) {
 
             if (importConfigProperties.getBehaviors().isSkipAttributesForFederatedUser() && patchedUser.getFederationLink() != null) {
                 patchedUser.setAttributes(null);
-            } else if (existingUser.getAttributes() != null && userToImport.getAttributes() != null) {
+            } else {
                 patchedUser.setAttributes(userToImport.getAttributes());
             }
 

src/test/java/de/adorsys/keycloak/config/service/ImportUsersIT.java

@@ -25,6 +25,7 @@
 import de.adorsys.keycloak.config.exception.InvalidImportException;
 import de.adorsys.keycloak.config.model.RealmImport;
 import jakarta.ws.rs.NotAuthorizedException;
+import org.hamcrest.Matchers;
 import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
 import org.keycloak.admin.client.resource.RealmResource;
@@ -41,6 +42,7 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.*;
 import static org.hamcrest.core.Is.is;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 @SuppressWarnings({"java:S5961"})
@@ -709,6 +711,35 @@ void shouldRemoveKeycloakDefaultClientLevelRolesFromExistingServiceAccount() thr
         assertThat(keycloakNativeClientLevelRoles, empty());
     }
 
+    @Test
+    @Order(101)
+    void shouldUpdateAttributeOfUserWithoutAttributes() throws IOException {
+        doImport("61.1_create_realm_with_user_without_attributes.json");
+
+        RealmRepresentation createdRealm = keycloakProvider.getInstance().realm(REALM_NAME).toRepresentation();
+
+        assertThat(createdRealm.getRealm(), is(REALM_NAME));
+        assertThat(createdRealm.isEnabled(), is(true));
+
+        UserRepresentation createdUser = keycloakRepository.getUser(REALM_NAME, "myuser61@mail.de");
+        assertThat(createdUser.getUsername(), is("myuser61@mail.de"));
+        assertThat(createdUser.getEmail(), is("myuser61@mail.de"));
+        assertThat(createdUser.isEnabled(), is(true));
+        assertThat(createdUser.getFirstName(), is("My firstname"));
+        assertThat(createdUser.getLastName(), is("My lastname"));
+
+        Map<String, List<String>> createdUserAttributes = createdUser.getAttributes();
+        assertThat(createdUserAttributes, Matchers.nullValue());
+
+        doImport("61.2_update_user_set_attributes.json");
+        UserRepresentation updatedUser = keycloakRepository.getUser(REALM_NAME, "myuser61@mail.de");
+
+        Map<String, List<String>> updatedUserAttributes = updatedUser.getAttributes();
+        assertThat(updatedUserAttributes, Matchers.notNullValue());
+        assertEquals(1, updatedUserAttributes.size());
+        assertThat(updatedUserAttributes.get("locale"), contains("de"));
+    }
+
     private List<GroupRepresentation> getGroupsByUser(UserRepresentation user) {
         return keycloakProvider.getInstance().realm(REALM_NAME).users().get(user.getId()).groups();
     }

src/test/resources/import-files/users/61.1_create_realm_with_user_without_attributes.json

@@ -0,0 +1,14 @@
+{
+  "enabled": true,
+  "realm": "realmWithUsers",
+  "internationalizationEnabled": true,
+  "users": [
+    {
+      "username": "myuser61@mail.de",
+      "email": "myuser61@mail.de",
+      "enabled": true,
+      "firstName": "My firstname",
+      "lastName": "My lastname"
+    }
+  ]
+}

src/test/resources/import-files/users/61.2_update_user_set_attributes.json

@@ -0,0 +1,19 @@
+{
+  "enabled": true,
+  "realm": "realmWithUsers",
+  "internationalizationEnabled": true,
+  "users": [
+    {
+      "username": "myuser61@mail.de",
+      "email": "myuser61@mail.de",
+      "enabled": true,
+      "firstName": "My firstname",
+      "lastName": "My lastname",
+      "attributes": {
+        "locale": [
+          "de"
+        ]
+      }
+    }
+  ]
+}