PR #2787 - Fix Tests

[l0gicgate]

So I removed CallableResolver and renamed AdvancedCallableResolver to be just CallableResolver. We don't need to implement both, our implementation implements the AdvancedCallableResolverInterface which extends the regular CallableResolverInterface.

I fixed all the tests, just to point out that it was messed up because the regular CallableResolver was binding the closure automatically from within the resolve() method's logic and then the MiddlewareDispatcher was rebinding it again.

Anyway, it's all fixed, 100% coverage. Please review after merging.

[adriansuter]

Cool. I will review, after my cycling tour. Thanks.

The reason I left the CallableResolver in our code and tried to rewrite the test cases to test both cases was, that we can make sure that the "old" way was still working as expected for most scenarios.

If for example a user copied the whole code of the CallableResolver and only made small modifications to provide a custom resolver, then we can guarantee, that his code (based on our own "old" code) would still work.

So you think, we don't have to guarantee that?

[l0gicgate]

We don’t have to guarantee anything about a user implementing their own CallableResolver. I did write some test cases for the case of a non AdvancedCallableResolverInterface though that cover everything.