Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for medusa 1.8 @next #181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adrien2p
Copy link
Owner

WIP

adrien2p and others added 2 commits February 28, 2023 12:20
* chore(deps): bump @sideway/formula from 3.0.0 to 3.0.1 (#173)

* fix: loaders & lint path

* fix: fixes loading for 1.9 server

* fix: package.json

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: SGF <SGF@sourcegoodfood.com>
@Arsenalist
Copy link

Arsenalist commented Apr 7, 2023

Is this PR ready to merge? I can help test.

@Arsenalist
Copy link

I have been testing this since yesterday with latest Medusa 1.8 and Extender 1.8.8, and unless you're using custom repositories, everything seems to work.

I am using pretty much all aspects of extender and the only issue I ran into with was cases where I was overrriding repositories, where I got compilation errors in the index.d.ts files. I have removed custom repositories and instead get the repository using TypeORM directly like this now:

em.getRepository(MyCustomProduct)

This seems to work fine.

The other issue is that extender still depends on older TypeORM which fails npm i but using npm i --force installs fine. I'm assuming that we'll be updating extender to use TypeORM 3 in the next release, and when that happens things should be good.

Great work on this!! Extender has made my life a lot easier.

@adrien2p
Copy link
Owner Author

Thanks a lot 🙏 the extender will be deprecated and we are writing a migration guide to move to a full medusa set up. I keep this pr open for those who are in needs of a smooth transition 😅 hope that's fine for you.

@mein-beer-hu
Copy link

Hello folks, first off thank you for a great repo, I was trying to follow a previous guide in Medusa blog about how we can create a marketplace by leveraging medusa-extender, but now it looks like this is being deprecated.

Does that mean if we are using medusa 1.8+, these extensions can be build on top of medusa itself?
Any information regarding how we can proceed here will be very helpful. thank you in advance.

@mewulonu
Copy link

mewulonu commented Jun 7, 2023

Hello @adrien2p , Is there an ETA on migration guide. We have alot of custom repositories we'd like to keep but running into compile time issues when upgraded to MedusaJS 1.8.1

@SGFGOV
Copy link
Contributor

SGFGOV commented Jun 7, 2023 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants