Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug slack channel archive #69

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Bug slack channel archive #69

wants to merge 75 commits into from

Conversation

jcolson
Copy link
Contributor

@jcolson jcolson commented Mar 3, 2019

bug #68 as well as fixing archiving

jcolson and others added 30 commits February 6, 2019 13:01
@jcolson
added LUSERS function
913770c
@jcolson
indexOf was not tested properly ... test for > -1
7889d2e
@jcolson
added patch adsr#55
48d2ac8
@jcolson
Merge branch 'patch55'
ad73bfe
@jcolson
added functionality for /WHO
a1d9186
@jcolson
changed quotes to doubles, changed hostname to be consistant irslackd
1602e02
@jcolson
added ability to /invite user
e47fb86
@jcolson
replaced all double qutoes for singles
efd99bb
@jcolson
catch exceptions on invite and give error feedback to user
2613ee1
@jcolson
formatting changes, lint made me do it
58591c3
@jcolson
fixed merge conflict and eslint'd
cfdd495
@jcolson
switched from channel.invite to conversations.invite
9dcc516
@jcolson
updated test_invite
094d302
@jcolson
changed plan number
664d07b
@jcolson
data element during testing was null, causing an unexpected exception…
a5d13d5 
…, test for undefined
@jcolson
used ircToSlack map instead of lookupUserId
2900f15
@jcolson
throw an exception instead of sending error to ircclient right away
9da1d69
@jcolson
use ircToSlack map instead of lookupChannelId
37c76e2
@jcolson
invite test almost working
d0e35e2
@jcolson
invite_test working now
c8949ca
@jcolson
removed console debug for invite function
43f4e4e
@jcolson
throw exception if id's aren't found in map
c041f23
@jcolson
added not in cache exception test for invite
4ae0d80
@jcolson
added test for /who
cfd3b0a
@jcolson
changed implementation of /who to use locally cached slack info
88a64d5
@jcolson
commented out debug
3ae753a
@jcolson
added functionality for /topic and also command line option to mark c…
b033c35 
…hannels read
@jcolson
replaced the slack ids with the irc comperables for the ircd.write of…
b1f281f 
… the invite success
@jcolson
fixed the /who #channel
acaf507
@jcolson
Merge branch 'feature-who' into develop
784d4c9 
* feature-who:
  fixed the /who #channel
jcolson added 30 commits February 24, 2019 21:31
@jcolson
write END of who AFTER all async who responses for channel
0e7e903
@jcolson
write END of who AFTER all async who responses for channel
ecc0e98
@jcolson
fixed async issue with end who
78d8243
@jcolson
Merge branch 'feature-who' into develop
2ef33fd 
* feature-who:
  fixed async issue with end who
  write END of who AFTER all async who responses for channel

# Conflicts:
#	lib/irslackd.js
@jcolson
(really) fixed END for WHO this time. also fixed who to show Here and…
01a2370 
… Gone
@jcolson
Merge branch 'feature-who' into develop
a9af063 
* feature-who:
  (really) fixed END for WHO this time.  also fixed who to show Here and Gone
@jcolson
added additional whois output
ac35301
@jcolson
fixed message number for whoisserver (312)
99cbe3a
@jcolson
don't run onslackready if already running
797e75f
@jcolson
moving timestamp for channels.mark one minute ahead works on smaller …
59d35b9 
…instances, however on systems with some latency it's not working. Overkill, moving it an hour ahead to see if it works on more latent slack instance.
@jcolson
changed test to look for irc values, not slack values
f18ee0a
@jcolson
changed from slack user name to ircNickId
5de4415
@jcolson
merge 5de4415
c99cc47
@jcolson
from adsr: Checking for leading '@' on usernames might be a cool fe…
480e41d 
…ature but I'd rather make that change for all commands at once rather than having support for it only for `/invite`
@jcolson
missded the second ircNickId in onIrcWho
8b77174
@jcolson
merged from who
d6d33c0
@jcolson
adsr: Can we call users.info synchronously in /who instead
56cc3e4
@jcolson
getting tests working again after changes
3bb9902
@jcolson
merge and getting tests to work
3e4b328
@jcolson
test works on later branch, merging the code into kick branch
d0325d4
@jcolson
kick test working
5911ca1
@jcolson
test_who is working now. changed the async arrow function foreach imp…
e71221b 
…lementation to a for of in order to make sure responses are back prior to test finishing.
@jcolson
added test_topic for /topic
58e372c
@jcolson
working on channel_archive and channel_deleted
4b57c56
@jcolson
WIP rename issue adsr#68
08744b5
@jcolson
added subtype group_name and groups.mark call
ae9394e
@jcolson
fixed being able to /part private channels ... especially when you're…
d64aa1d 
… the last one in them (needed a call to conversations.archive in the case that last_member error is thrown)
@jcolson
make sure exception data is json and not undefined for the leaving of…
062101f 
… slack channel
@jcolson
removed debug logs
f057b64
@jcolson
handle group_archive as well as fixed a bug in onslackchanneljoin for…
75e2f8a 
… newly created channels
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcolson