Skip to content

Styles not working as expected #142

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
sagar-accacia opened this issue Jan 15, 2024 · 2 comments
Closed

Styles not working as expected #142

sagar-accacia opened this issue Jan 15, 2024 · 2 comments

Comments

@sagar-accacia
Copy link

Describe the bug
Element Style not applied to the resizeable element instead is applied to the inner element.

To Reproduce
Steps to reproduce the behavior:

  1. Create a space
  2. Try to pass styles directly to the space
  3. Inspect in DevTools
  4. Styles applied to inner div

Expected behavior
Styles should be applied to the same div/element which the space is created in.

Screenshots
image
image

Package versions (please complete the following information):

  • "react-spaces": "^0.4.1"
  • "react": "18.1.0"
  • "next": "13.5.6"

Desktop (please complete the following information):

  • OS: macOS
  • Browser chrome
  • Version 120.0.6099.109

Code sandbox link
https://codesandbox.io/p/sandbox/sparkling-morning-gjjlz4?file=%2Fsrc%2FApp.js%3A28%2C37
the-e3n pushed a commit to sagar-accacia/react-spaces that referenced this issue Mar 24, 2024
FIX: a bug where the styles pass to the resizable component were not …
550587e 
…passed the resizing component instead were being passed to a inner element that was created for the content thus transitions were not working aeagle#142
@sagar-accacia sagar-accacia mentioned this issue Mar 24, 2024
Merged
@aeagle aeagle closed this as completed in c72a9e2 Mar 30, 2024
@sagar-accacia
Copy link
Author

@aeagle when can i expect this to be released to npm ?

@aeagle
Copy link
Owner

aeagle commented Apr 22, 2024

@sagar-accacia This has been released in v0.5.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeagle @sagar-accacia