Merge pull request #281 from jorritmesman/main

Can use plot_LHC also when not calibrating Kw
aemon-j · Apr 25, 2024 · 625e258 · 625e258
2 parents 653442d + 956eb48
commit 625e258
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: LakeEnsemblR
 Type: Package
 Title: Run Ensemble of Lake Models
-Version: 1.2.6
-Date: 2023-09-19
+Version: 1.2.7
+Date: 2024-04-25
 URL: https://github.com/aemon-j/LakeEnsemblR
 Author: Authors@R: c(person("Tadhg", "Moore", role = c("aut","cre"),
     email = "tadhg.moore6@gmail.com"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+## version 1.2.7
+
+### Changes
+- bug fix of `plot_LHC` function; can be used also when not calibrating `Kw`
+
 ## version 1.2.6
 
 ### Changes

diff --git a/R/plot_LHC.R b/R/plot_LHC.R
@@ -39,7 +39,11 @@ plot_LHC <- function(config_file, model, res_files, qual_met = "rmse", best_quan
   # meteo parameter
   met_pars <- names(configr_master_config[["calibration"]][["met"]])
   # kw parameter
-  kw_pars <- "Kw"
+  if("Kw" %in% names(configr_master_config[["calibration"]])){
+    kw_pars <- "Kw"
+  }else{
+    kw_pars <- NULL
+  }
   # get names of models for which parameter are given
   model_p <- model[model %in% names(configr_master_config[["calibration"]])]
   # model specific parameters