[c++] Cast after modulo operation to avoid overflow. Issue #579.

aeron-io · Nov 14, 2018 · 0af9e1c · 0af9e1c
1 parent 750f915
commit 0af9e1c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/aeron-client/src/main/cpp/concurrent/logbuffer/LogBufferDescriptor.h b/aeron-client/src/main/cpp/concurrent/logbuffer/LogBufferDescriptor.h
@@ -270,7 +270,7 @@ inline static int indexByTermCount(std::int64_t termCount) AERON_NOEXCEPT
 
 inline static int indexByPosition(std::int64_t position, std::int32_t positionBitsToShift) AERON_NOEXCEPT
 {
-    return (int)((std::uint64_t)position >> positionBitsToShift) % PARTITION_COUNT;
+    return static_cast<int>(((std::uint64_t)position >> positionBitsToShift) % PARTITION_COUNT);
 }
 
 inline static std::int64_t computePosition(