[C] Windows fixes, next part #863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A function with the wrong signature was being passed to CreateThread - The thread handle was never closed - Failure to start a thread was not detected
- Lock/unlock did not work as an indirection was missing - Made the function prototypes match the Linux version - Added aeron_mutex_destroy
- The SOCKET type was incorrectly cast to int, even though it's larger - Renamed aeron_fd_t to aeron_socket_t as a socket handle is not a file descriptor on Windows
- Don't try to silently adjust the supplied length to the file size - off_t is 32 bits, so offset >> 32 generates a warning
|
It would be better to limit the scope of a PR. For example separate out addressing warnings from behavioural change. It is easier to discuss behaviour change in the context of each change. |
|
Yes, I understand. I didn't want to flood you with PRs, but I can split this into 6 or 7 PRs if you prefer. |
This was referenced Feb 20, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are larger fixes than in my last PR, I recommend reviewing this commit-by-commit.
The remaining warnings that MSVC outputs are:
size_tvalues toint(I'm surprised GCC doesn't warn about those)getsockoptandsetsockopthave achar*type for the value instead ofvoid*. It would be nice to have anaeron_*version of those to deal with those warnings if you're OK with that.Also, errors aren't currently logged properly on Windows (
strerroris kind of useless anderrnoisn't used by winsock). Fixing that would require replacing calls toaeron_set_errthat usestrerrorwith something similar to whataeron_set_windows_errordoes. I'm not yet sure about the best way to do it, but would you agree to such a change in principle?