You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() == version)
I haven't traced out the path from xml to sbeir to cpp, but I'm pretty sure that token.tokenVersion() comes from the XML's sinceVersion field. If so, a strict version match is not appropriate. I think the version check should be changed to an inequality.
if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() <= version)
Thanks.
The text was updated successfully, but these errors were encountered:
Line 114 of IrDecoder.h reads:
if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() == version)
I haven't traced out the path from xml to sbeir to cpp, but I'm pretty sure that token.tokenVersion() comes from the XML's sinceVersion field. If so, a strict version match is not appropriate. I think the version check should be changed to an inequality.
if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() <= version)
Thanks.
The text was updated successfully, but these errors were encountered: