Skip to content

otf_api is too strict about version comparison #970

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
aschw opened this issue Jan 28, 2024 · 0 comments
Closed

otf_api is too strict about version comparison #970

aschw opened this issue Jan 28, 2024 · 0 comments

Comments

@aschw
Copy link

aschw commented Jan 28, 2024

Line 114 of IrDecoder.h reads:

if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() == version)

I haven't traced out the path from xml to sbeir to cpp, but I'm pretty sure that token.tokenVersion() comes from the XML's sinceVersion field. If so, a strict version match is not appropriate. I think the version check should be changed to an inequality.

if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() <= version)

Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants