Skip to content

NPE in toString method of generated decoder (for bit sets) #976

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
pcdv opened this issue Feb 21, 2024 · 1 comment
Closed

NPE in toString method of generated decoder (for bit sets) #976

pcdv opened this issue Feb 21, 2024 · 1 comment

Comments

@pcdv
Copy link
Contributor

pcdv commented Feb 21, 2024

This is a copy of issue #708 : the same bug exists for sets.

I.e. the same fix is needed for the BEGIN_SET case.
@pcdv
Copy link
Contributor Author

pcdv commented Feb 21, 2024 •
edited
Loading

Looks like the fix is to merge these two cases at line 3337 (as of fix in previous comment) or 4567 as of now.

            case BEGIN_SET:
            case BEGIN_COMPOSITE:

pcdv pushed a commit to pcdv/simple-binary-encoding that referenced this issue Feb 21, 2024
[Java] Cope with optional sets not being present when pretty printing…
cede223 
… decoders for debugging. Issue aeron-io#976
@pcdv pcdv mentioned this issue Feb 21, 2024
Merged
mjpt777 pushed a commit that referenced this issue Feb 22, 2024
@pcdv
[Java] Cope with optional sets not being present when pretty printing…
a146c56 
… decoders for debugging. Issue #976 (#977)

Co-authored-by: Paul COLIN DE VERDIERE <paul.colindeverdiere@connect.hsoftware.com>
@pcdv pcdv closed this as completed Feb 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcdv