Skip to content

[C++] hide the m_codecStatePtr behind ifdefs to avoid overhead when p… #1036

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

nbradac
Copy link
Contributor

@nbradac nbradac commented Dec 12, 2024

…recedence checking is disabled

The m_codecStatePtr is now only defined when SBE_ENABLE_PRECEDENCE_CHECKS is defined. The various setter/getter functions still exist when _CHECKS is not defined to keep the rest of the code simpler, but they do nothing and should be optimized away.

@nbradac nbradac requested a review from ZachBray December 12, 2024 18:02
@vyazelenko vyazelenko merged commit 3199ae7 into aeron-io:master Dec 13, 2024
36 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants