Enable extra warnings (-Wextra) #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmontgomery What do you think about this patch? |
tmontgomery
reviewed
Sep 20, 2016
| @@ -4,4 +4,5 @@ | |||
| "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd"> | |||
| <suppressions> | |||
| <suppress files=".*generated.*" checks="."/> | |||
| <suppress files="CppGenerator.java" checks="MethodLength"/> | |||
There was a problem hiding this comment.
This is not something we want to suppress.
There was a problem hiding this comment.
I don't want to split up the constructor codegen function for no good reason. Should I do something like this:
void generateConstructor() {
generatePart1();
generatePart2();
}
There was a problem hiding this comment.
Yes it is best to break up large methods into logical blocks so they can be reasoned about.
|
a looking forward 80c53b6 in next release |
|
@tmontgomery @mjpt777 I've updated this PR to ignore -Wtype-limits in wrapForEncode instead of the more complicated change i previously had. This PR is a superset of #421 |
|
@tmontgomery @mjpt777 Any thoughts on this? |
|
Sorry this took so long. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable extra warnings and fix those warnings.