[golang] Issue #435 References inside messageHeader not working #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate the MessageHeader as though it was a composite as it's not compulsorarily standardized in the standard. Provide an optimized separate MessageHeader for use when people follow the recommended MessageHeader as most people will do just that. Fix <ref tags> to use the underlying type find token.acceptableTypeName() rather than token.name(). In golang references had previously been worked around for sets/choices/composites but not MessageHeaders. This makes them all work the same way and more properly but it does introduce some monor changes to generated types. Fix the tests, examples and benchmarks to reflect these changes, adding an issue435.xml for testing with test code to match. Fix the java interop test which used the sbe-samples example-schema which has now been modified. This also causes the bigendian test to be revised. Documentation updates to match.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the MessageHeader as though it was a composite as it's not compulsorarily standardized in the standard.
Provide an optimized separate MessageHeader for use when people follow the recommended MessageHeader as most people will do just that.
Fix to use the token.acceptableTypeName() rather than token.name(). In golang references had previously been worked around for sets/choices/composites but not MessageHeaders. This makes them all work the same way and more properly but it does introduce some minor changes to generated types.
Fix the tests, examples and benchmarks to reflect these changes, adding an issue435.xml for testing with test code to match.
Fix the java interop test which used the sbe-samples example-schema which has now been modified. This also causes the bigendian test to be revised.
Documentation updates to match.