-
Notifications
You must be signed in to change notification settings - Fork 539
[C++] Methods to calculate the length of an SBE message #761
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
e04fe8c
to
693c052
Compare
This pull request introduces 1 alert when merging 693c052 into 6ec0439 - view on LGTM.com new alerts:
|
Will look in more detail in at a later date. Got a bit too much on at the minute. One thing on naming. Something that will calculate the total so be named to reflect that it is not a simple accessor. Something like |
@mjpt777 noticed. New function names are: |
I see you were fixing some warnings in addition to this. I've picked those up independently. |
I've rebased on master |
Be good to get @tmontgomery view on this. |
Implements: #291