-
Notifications
You must be signed in to change notification settings - Fork 539
Indexed fields as spans #780
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b34653f.
@billsegall Do you have any views on this? |
I think it's a useful helper function. I see no compatibility issues. |
Could we get this change merged up and a new version of the sbe-tool NuGet package published? Is there anything I can help with to get this done? |
A new nuget release is probably due. I'll do that post merge.
Bill.
…On Sat, 16 May 2020 at 20:44, Dr. James Gate ***@***.***> wrote:
Could we get this change merged up and a new version of the sbe-tool NuGet
package published? Is there anything I can help with to get this done?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJDLJACW5US2QMGFCN5UETRRZU65ANCNFSM4NAFIKEA>
.
|
mjpt777
added a commit
that referenced
this pull request
May 16, 2020
I've done a nuget release as 1.17.1. Consistent versioning across all backend languages is a little tricky. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes an array field as a
ReadOnlySpan
.This was motivated by the need to store a GUID in a field. The natural way to do this is using a field of 16 bytes, which means the way to extract and encode it requires copying to an intermediate array. The C# GUID struct provides a
ReadOnlySpan
constructor, allowing us to create a GUID without copying to an intermediate byte buffer, e.g.:and for encoding store:
then set it using:
I've also added an
AsSpan()
method, to support writing directly from a Guid object to the underlying array. This allows you to write a Guid like this: