Skip to content

C++ code generation: check composite and bitset version #888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

greenstein
Copy link
Contributor

Previously, the C++ generated code did not check the version before writing composite and bitset fields to the output stream. This leads to undefined behavior. I've updated the generated code to first check if the field is in the acting version before writing it to the stream.

@tmontgomery
Copy link
Contributor

I'm good with this assuming it passes the build.

@mjpt777 mjpt777 merged commit e43fb20 into aeron-io:master Jan 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants