Skip to content

[CLIENT-2760] Move raise exception code to aerospike module #698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 59 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Nov 25, 2024

Extra changes:

  • Create a dummy package called aerospike. Rename the aerospike extension module to _aerospike and place under this dummy package

running importlib.import_module while an AerospikeError is set causes it to fail

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 74.41860% with 44 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (ca2f4be) to head (8869287).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/aerospike.c 75.72% 25 Missing ⚠️
src/main/client/info.c 33.33% 6 Missing ⚠️
src/main/exception.c 61.53% 5 Missing ⚠️
src/main/query/where.c 0.00% 3 Missing ⚠️
src/main/client/sec_index.c 50.00% 2 Missing ⚠️
src/main/scan/apply.c 0.00% 2 Missing ⚠️
src/main/client/batch_get_ops.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #698      +/-   ##
==========================================
- Coverage   80.89%   80.19%   -0.71%     
==========================================
  Files         102      102              
  Lines       15186    15019     -167     
==========================================
- Hits        12285    12044     -241     
- Misses       2901     2975      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants