Skip to content

[CLIENT-3188] Fix unraisable exception warnings in Python 3.13 #751

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 35 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 9, 2025

Extra changes:

  • Fix bug where certain API calls delete attributes from exceptions that inherit AerospikeError
  • (TODO: document old behavior) batch_write() raises a ParamError exception if the argument batch_records is not of type aerospike_helpers.batch.records.BatchRecords
  • Refactor: improve helper function that checks aerospike_helper class instances

TODO

  • src/main/client/batch_write.c test needs to be changed

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 88.77551% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (3767582) to head (2894954).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/exception.c 86.66% 4 Missing ⚠️
src/main/client/info.c 0.00% 3 Missing ⚠️
src/main/client/operate.c 91.89% 3 Missing ⚠️
src/main/client/sec_index.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #751      +/-   ##
==========================================
- Coverage   81.02%   80.85%   -0.17%     
==========================================
  Files         102      102              
  Lines       15235    14992     -243     
==========================================
- Hits        12344    12122     -222     
+ Misses       2891     2870      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-3188] Fix client.operate() printing about unraisable warnings in Python 3.13 [CLIENT-3188] Fix unraisable exception warnings in Python 3.13 Apr 9, 2025
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-3188-fix-pytest-unraisable-warnings branch from 6f52774 to b03a53c Compare April 10, 2025 22:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants